Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command file required for PrettyPrintCert #4889

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

fmarco76
Copy link
Member

F41 does not include the file command in the default installation and need to be installed because it is used by PrettyPrintCert to distinguish between pem and der certificates.

Solve EST CI error: https://github.com/dogtagpki/pki/actions/runs/11614781119/job/32344308552#step:25:27

F41 does not include the `file` command in the default installation and
need to be installed because it is used by PrettyPrintCert to
distinguish between pem and der certificates.
@fmarco76 fmarco76 requested a review from edewata October 31, 2024 16:09
Copy link

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think in some places we try to parse the input as DER first then fallback to PEM, so we might be able to drop this dependency (in a separate PR later).

@edewata edewata merged commit 60d5348 into dogtagpki:master Nov 1, 2024
154 of 168 checks passed
@edewata
Copy link
Contributor

edewata commented Nov 1, 2024

@fmarco76 I went ahead and merged this PR. Thanks!

@fmarco76 fmarco76 deleted the FixCIF41 branch November 4, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants