Initialize Urls property with an empty collection #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t null values Updated the `Urls` property in `ConfigObject` to initialize with `Enumerable.Empty<UrlDescriptor>()` instead of `null`. This change ensures the property is always a valid collection, eliminating the need for null checks and preventing potential null reference exceptions when accessing or iterating over the property. Improves code safety and aligns with best practices for handling collections.
averichev
changed the title
|
I don't have a problem with this unless Swagger UI treats empty and null/undefined differently.
With the qualifier "by default" - there's nothing to stop it being null. |
|
This pull request is stale because it has been open for 60 days with no activity. It will be automatically closed in 14 days if no further changes are made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
Urlsproperty inConfigObjectto initialize withEnumerable.Empty<UrlDescriptor>()instead ofnull. This change ensures the property is always a valid collection, eliminating the need for null checks and preventing potential null reference exceptions when accessing or iterating over the property. Improves code safety and aligns with best practices for handling collections.