Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ts solution to lc problem: No.0001 #2012

Merged
merged 6 commits into from
Nov 24, 2023
Merged

feat: add ts solution to lc problem: No.0001 #2012

merged 6 commits into from
Nov 24, 2023

Conversation

iam-abhishek-yadav
Copy link
Contributor

No description provided.

@idoocs
Copy link
Member

idoocs commented Nov 24, 2023

🤭 感谢你的提交,请检查你的改动是否符合以下项目规范。

1. 格式化

我们项目中各种编程语言代码(包括文档)所采用的格式化工具不同,提交 pr 之前必须确保代码、文档正确格式化。

  • .{md,js,ts,php,sql,rs} 采用 prettier
  • .{c,cpp,java} 采用 clang-format
  • .{py} 采用 black
  • .{go} 采用 gofmt
  • 其它待完善

2. Git 提交信息

我们项目遵循 AngularJS Git Commit Message Conventions 规范,我们希望你的提交信息尽可能与项目保持一致。

  • 新增或修改题解:feat: add/update solution(s) to lc problem(s): No.xxxx
  • 修复错误:fix: xxxx
  • 日常维护:chore: xxx

3. 其它补充

新增题解及代码时,需要创建 Solution.xxx 源代码文件(如果已存在,请确认算法是否更优,是则覆盖已有算法代码),同时,需要在 README.md 以及 README_EN.md 中添加对应的代码片段(英文文件中不要出现中文注释)

另外,编码风格(比如变量、函数的命名),尽量跟项目已有代码保持一致。


🤭 Thank you for your contribution. Please check if your changes comply with the following project specifications.

1. Formatting

We use different formatting tools for various programming languages (including documentation) in our project. You must ensure that the code and documentation are correctly formatted before submitting a pr.

  • .{md,js,ts,php,sql,rs} use prettier
  • .{c,cpp,java} use clang-format
  • .{py} use black
  • .{go} use gofmt
  • Others to be improved

2. Git Commit Message

Our project follows the AngularJS Git Commit Message Conventions. We hope that your submission information is as consistent as possible with the project.

  • Add or modify solutions: feat: add/update solution(s) to lc problem(s): No.xxxx
  • Fix errors: fix: xxxx
  • Routine maintenance: chore: xxx

3. Other notes

When adding solutions and code, you need to create a Solution.xxx source code file (if it already exists, please confirm whether the algorithm is better, if yes, overwrite the existing algorithm code), and at the same time, you need to add the corresponding code snippets in README.md and README_EN.md (do not have Chinese comments in the English file)

In addition, the coding style (such as the naming of variables and functions) should be as consistent as possible with the existing code in the project.

@idoocs idoocs added the ts Issues or Pull requests relate to .ts code label Nov 24, 2023
@thinkasany
Copy link
Member

Hello contributor, thank you very much for your contributions. Your code is great, but there are still areas of concern. In fact, you can omit returning the empty array, you can do this by modifying the test cases and you will find that all test cases must have the correct return value. Also, you can refer to other languages for writing style and variable naming, because the purpose of our project is to make it easier for users to understand the usage of other languages, which is more in line with the problem solution we provide, and you can also remove comments, which is more in line with the style of the project.
image

@thinkasany thinkasany changed the title feat: add solutions to lc problem: No.0001 feat: add ts solution to lc problem: No.0001 Nov 24, 2023
@thinkasany
Copy link
Member

Since we already provide solutions, we don't need to add comments in the middle of the code, you can refer to js and add the type declaration of Map for m.
image

@thinkasany
Copy link
Member

You can add this code in README_EN.md and README_EN.md files, so that it can be shown in the document, thanks again for your contribution!
`

### **TypeScript**

```ts
function twoSum(nums: number[], target: number): number[] {
    const m: Map<number, number> = new Map();

    for (let i = 0; ; ++i) {
        const x = nums[i];
        const y = target - x;

        if (m.has(y)) {
            return [m.get(y)!, i];
        }

        m.set(x, i);
    }
}

`

@idoocs idoocs added the md Issues or Pull requests relate to .md files label Nov 24, 2023
@thinkasany thinkasany merged commit 623b53d into doocs:main Nov 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
md Issues or Pull requests relate to .md files ts Issues or Pull requests relate to .ts code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants