Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add solutions to lc problem: No.3385 #3856

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat: add solutions to lc problem: No.3385 #3856

merged 1 commit into from
Dec 13, 2024

Conversation

yanglbme
Copy link
Member

No description provided.

@yanglbme yanglbme requested a review from Copilot December 13, 2024 01:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated 3 comments.

Files not reviewed (3)
  • solution/README.md: Evaluated as low risk
  • solution/3300-3399/3377.Digit Operations to Make Two Integers Equal/README.md: Evaluated as low risk
  • solution/3300-3399/3377.Digit Operations to Make Two Integers Equal/README_EN.md: Evaluated as low risk
Comments suppressed due to low confidence (3)

solution/3300-3399/3385.Minimum Time to Break Locks II/Solution.java:14

  • [nitpick] The class name _Edge is unconventional for Java. Consider renaming it to EdgeInternal.
static class _Edge {

solution/3300-3399/3385.Minimum Time to Break Locks II/Solution.java:175

  • [nitpick] The class name Tuple is not very descriptive. Consider renaming it to EdgeTuple.
static class Tuple {

solution/3300-3399/3385.Minimum Time to Break Locks II/README_EN.md:328

  • The 'Tuple' class is used but not defined anywhere, which will cause a compilation error.
class MCFGraph {

@@ -186,13 +186,348 @@ edit_url: https://github.com/doocs/leetcode/edit/main/solution/3300-3399/3385.Mi
#### Python3

```python

class MCFGraph:
Copy link
Preview

Copilot AI Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'NamedTuple' import is missing, which will cause a runtime error.

Suggested change
class MCFGraph:
from typing import NamedTuple

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
self.dst = dst
self.cap = cap
self.cost = cost
self.rev: Optional[MCFGraph._Edge] = None
Copy link
Preview

Copilot AI Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'Optional' and 'List' types are used without being imported from the 'typing' module, which will cause runtime errors.

Suggested change
self.rev: Optional[MCFGraph._Edge] = None
from typing import List, Optional

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
}

private boolean refineDual(int s, int t, int[] dual, Tuple[] prev) {
PriorityQueue<int[]> pq = new PriorityQueue<>(Comparator.comparingInt(a -> a[0]));
Copy link
Preview

Copilot AI Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'Comparator' import is missing, which will cause a compilation error.

Suggested change
PriorityQueue<int[]> pq = new PriorityQueue<>(Comparator.comparingInt(a -> a[0]));
import java.util.Comparator;

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@yanglbme yanglbme merged commit 47324f6 into main Dec 13, 2024
6 checks passed
@yanglbme yanglbme deleted the dev branch December 13, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant