-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CODEOWNERS and validation #1153
Conversation
8cd2bc8
to
8f732b5
Compare
|
The build failure seems unrelated - filed #1160 in response. |
@ellahathaway - would you mind updating the How to modify or create a new image section of the readme to explain that a team code owner must be defined for each Dockerfile and what the responsibilities are? TIA |
Addressed in #1161 |
Closes #1148
This PR assigns an owner to each dockerfile in the repo & adds PR validation to check that each dockerfile has an owner. The idea is to ping the owner of the file (if a team) or assign the owner to the issue (if an individual).
I did assignments based on git history and the information I received from asking folks which files they own. I had to guess on the ownership of some of the files based on the git history.
We may need to assign write access to the repo for those in the codeowners file with red/error lines.
Here is a link to a sample PR where I tested the validation. This is an example of passing validation and this is an example of failing validation.
NOTE: I don't see the "Actions" tab in this repo, so we may have to enable it for this repo: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository