Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to non-preview tagging pattern for .NET 9 #5821

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Switch to non-preview tagging pattern for .NET 9 #5821

merged 7 commits into from
Aug 27, 2024

Conversation

lbussell
Copy link
Contributor

Fixes #5055

  • Remove preview suffix from tags in manifest.json and/or manifest.versions.json
  • Move new version tags out of preview sub-tables in MCR tags metadata templates
  • In readme templates:
    • Switch Featured Tags from "(Preview)" to "(Release Candidate)" in nightly branch
    • Add new .NET Version to Featured Tags as "(Release Candidate)" in main branch

@lbussell lbussell requested review from jander-msft and a team as code owners August 20, 2024 20:01
mthalman
mthalman reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview needs to be disabled for the tests too:

dotnet-docker/tests/Microsoft.DotNet.Docker.Tests/ImageVersion.cs

Line 18 in cda2660

public static readonly ImageVersion V9_0 = new(new Version(9, 0), isPreview: true);

@lbussell lbussell enabled auto-merge (squash) August 21, 2024 17:06
@lbussell lbussell merged commit 1627686 into dotnet:nightly Aug 27, 2024
112 checks passed
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Sep 9, 2024
@lbussell
Switch to non-preview tagging pattern for .NET 9 (dotnet#5821)
951273e
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Sep 9, 2024
@lbussell
Switch to non-preview tagging pattern for .NET 9 (dotnet#5821)
7c67aae
@lbussell lbussell mentioned this pull request Sep 11, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jander-msft jander-msft jander-msft approved these changes

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
area-infrastructure untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbussell @mthalman @jander-msft