Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to implicit DbContext registration around factories #35486

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

roji
Copy link
Member

@roji roji commented Jan 16, 2025

Fixes #26528
Fixes #35485

@roji roji requested a review from AndriySvyryd January 16, 2025 11:55
@roji roji requested a review from a team as a code owner January 16, 2025 11:55
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also update https://learn.microsoft.com/ef/core/performance/advanced-performance-topics#managing-state-in-pooled-contexts to remove the need of registering the context. Also mention that when a factory is registered it's slightly more performant to depend on the factory than on the context, even if only one instance will be used.

@AndriySvyryd
Copy link
Member

And this fixes #26528, not #35484

@roji roji merged commit 47e5d25 into dotnet:main Jan 16, 2025
7 checks passed
@roji roji deleted the DbContextStuff branch January 16, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants