Fixed lazy loading thread safety #35529
Open
+78
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added sync for lazy loading Fixes dotnet#35528
|
@dotnet-policy-service agree |
henriquewr
commented
Jan 25, 2025
| var willWait = true; | ||
| TaskCompletionSource taskCompletionSource; | ||
|
|
||
| lock (_isLoadingLock) |
There was a problem hiding this comment.
i don't know exactly why
but i need do lock the access to the GetOrAdd, otherwise the code breaks again
my guess it's because of the implementation of GetOrAdd which are 2 separete methods
if (!TryGetValueInternal(tables, key, hashcode, out TValue? resultingValue))
{
TryAddInternal(tables, key, hashcode, valueFactory(key), updateIfExists: false, acquireLock: true, out resultingValue);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sync for lazy loading
Fixes #35528