Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made imports canonical, suppresses IDE errors. #32

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Jun 25, 2024

🚀 This description was created by Ellipsis for commit b1978cf

Summary:

Updated import statements to use canonical paths across multiple files to ensure consistency and suppress IDE errors.

Key points:

  • Updated import statements to use canonical paths in wikimedia/entries/download.py, wikimedia/entries/entry.py, wikimedia/executors/downloader.py, wikimedia/utilities/emailer.py, wikimedia/utilities/iiif.py, and wikimedia/utilities/tracker.py.
  • Ensured consistency in import paths to suppress IDE errors.
  • No functional changes to the code logic.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b1978cf in 19 seconds

More details
  • Looked at 94 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. wikimedia/entries/download.py:12
  • Draft comment:
    The changes to the import paths are consistent and correctly reflect the intended project structure. This should help in maintaining clarity in module usage and avoid potential import conflicts.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR is focused on making imports canonical by adding the 'wikimedia' prefix to all internal imports. This is a good practice for avoiding conflicts and making the module paths clear, especially in larger projects or when the code might be used as a library. I will check if the changes are consistent across all modified files and if they align with the project's structure.

Workflow ID: wflow_XpakeguEopG5yeBK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mdellabitta mdellabitta merged commit 291838b into main Jun 25, 2024
3 checks passed
@mdellabitta mdellabitta deleted the fixup-imports branch June 25, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant