Fix no such key

[mdellabitta]

Important

Handle missing S3 keys by returning None and update processing logic to track missing items, adding types-boto3-s3 dependency.

• Behavior:
  • Handle NoSuchKey exception in get_item_file() in s3.py, returning None if key is missing.
  • Update get_item_metadata() and get_file_list() in s3.py to return None or empty list if file is missing.
  • Modify process_item() in uploader.py to increment Result.ITEM_NOT_PRESENT if metadata is missing.
• Enums:
  • Add ITEM_NOT_PRESENT to Result enum in tracker.py.
• Dependencies:
  • Add types-boto3-s3 to pyproject.toml and uv.lock for type checking support.
• Misc:
  • Fix platform marker for colorama in uv.lock.

^{This description was created by for 706c19a. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 706c19a in 1 minute and 1 seconds

More details

• Looked at 162 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. ingest_wikimedia/s3.py:136

• Draft comment:
  The return type hint for get_item_file should be updated to Optional[str] to reflect that it can return None. This applies to get_item_metadata as well.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. ingest_wikimedia/s3.py:105

• Draft comment:
  Check if get_item_file returns None before calling split to avoid AttributeError.
• Reason this comment was not posted:
  Marked as duplicate.

3. tools/uploader.py:186

• Draft comment:
  Ensure consistency in handling None return values from get_item_metadata and get_file_list. Consider checking for None before further processing.
• Reason this comment was not posted:
  Marked as duplicate.

4. ingest_wikimedia/s3.py:133

• Draft comment:
  Avoid hardcoding sensitive information like S3 bucket names. Consider using environment variables or a secure vault.
• Reason this comment was not posted:
  Comment was not on a valid diff hunk.

Workflow ID: wflow_A6qcegKAYMoHz3oc

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.