Fixes for creator field

[mdellabitta]

Made markup different per https://commons.wikimedia.org/wiki/User_talk:Dominic#DPLA_bot_use_of_InFi_for_creator_field

Omit creator when missing.

---

Important

Update get_wiki_text to conditionally include creator field based on presence, with corresponding test updates.

• Behavior:
  • Update get_wiki_text in wikimedia.py to conditionally include creator field in template only if present.
  • If creator is missing, omit the creator field from the template.
• Tests:
  • Update test_get_wiki_text in test_wikimedia.py to verify behavior with and without creator field.

^{This description was created by for f2ebcbc. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to f2ebcbc in 42 seconds

More details

• Looked at 68 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. tests/test_wikimedia.py:163

• Draft comment:
  The test for get_wiki_text without a creator should explicitly verify that the creator field is omitted from the output. Consider adding an assertion to check that the creator field is not present in text.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The current test is already comprehensive - it checks the exact text output character by character. If the creator field was present when it shouldn't be, the test would fail. An additional assertion would be redundant since we're already doing an exact string match. The suggestion would add test complexity without adding value.
  Perhaps an explicit assertion about the creator field would make the test's intention clearer to future readers? It could serve as documentation of what we're testing.
  While explicit assertions can be helpful for documentation, in this case the test is already clear and the expected_text clearly shows the intended structure without the creator field. Adding redundant assertions goes against testing best practices.
  Delete this comment because the existing exact string comparison test already thoroughly verifies the absence of the creator field. Adding another assertion would be redundant.

2. ingest_wikimedia/wikimedia.py:141

• Draft comment:
  Ensure no hardcoded API keys are present. Use environment variables or secure vaults for storing API keys.
• Reason this comment was not posted:
  Confidence changes required: 33%
  The code does not seem to have any hardcoded API keys, which is the only rule violation I am checking for.

Workflow ID: wflow_UoUYB7DVKHBBRvHW

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.