Increased connection timeout to 45 seconds

[mdellabitta]

Important

Increase connection timeout from 10 to 45 seconds in ingest_wikimedia/web.py.

• Behavior:
  • Increase DEFAULT_CONN_TIMEOUT from 10 to 45 seconds in ingest_wikimedia/web.py.
  • Affects get_http_session() function, setting a longer default timeout for HTTP requests.

^{This description was created by for 5a7093a. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 5a7093a in 13 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. ingest_wikimedia/web.py:14

• Draft comment:
  Increasing the connection timeout to 45 seconds is a significant change. Ensure this aligns with expected network performance and user experience, as it may lead to longer waits during network issues.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The increase in connection timeout from 10 to 45 seconds is a significant change. While it might be necessary for certain network conditions, it could also lead to longer waits in case of network issues. It's important to ensure that this change aligns with the expected network performance and user experience.

Workflow ID: wflow_lOjmuLHNNMD9xcY6

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.