Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SSPROD-37154): Add EKS Onboarding Terraform module #52

Merged
merged 31 commits into from
Mar 12, 2024

Conversation

alexeyovriakh
Copy link
Contributor

@alexeyovriakh alexeyovriakh commented Feb 7, 2024

Testing

Test AWS env: draios-dev

tfvars file:

clusters                = ["agentless-test-cluster"]
eks_role_name           = "AgentlessEKSRole"
deploy_global_resources = true
external_id             = "cc24d23f-57c1-4e4b-9dc1-e3ba1ec86dbb"
ecr_role_name           = "AgentlessECRPullImages"
trusted_identity        = "arn:aws:iam::059797578166:role/AgentlessEKSRole"

Run the following commands

tf init
tf apply -var-file="dev.tfvars"

@alexeyovriakh alexeyovriakh requested a review from a team as a code owner February 7, 2024 16:01
Copy link
Contributor

@blkt blkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the work ❤️ thank you @alexeyovriakh !

modules/services/eks/locals.tf Outdated Show resolved Hide resolved
modules/services/eks/main.tf Outdated Show resolved Hide resolved
modules/services/eks/provider.tf Outdated Show resolved Hide resolved
modules/services/eks/variables.tf Outdated Show resolved Hide resolved
Copy link
Contributor Author

@alexeyovriakh alexeyovriakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add README

@alexeyovriakh
Copy link
Contributor Author

@nkraemer-sysdig any chance you could have a look at this PR?

Also, do we generate the docs manually for this repo? How do you keep docs up-to-date?

@alexeyovriakh alexeyovriakh requested a review from a team as a code owner March 6, 2024 15:17
modules/services/eks/variables.tf Outdated Show resolved Hide resolved
modules/services/eks/iam.tf Outdated Show resolved Hide resolved
modules/services/eks/iam.tf Outdated Show resolved Hide resolved
@tembleking tembleking self-requested a review March 12, 2024 12:24
Copy link
Member

@tembleking tembleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Copy link
Contributor

@mms2409 mms2409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeyovriakh alexeyovriakh merged commit 4de08cc into main Mar 12, 2024
5 checks passed
@alexeyovriakh alexeyovriakh deleted the feat/SSPROD-37154/eks branch March 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants