Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use managed-execution in all stacksets #65

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

nkraemer-sysdig
Copy link
Contributor

Creating a aws_cloudformation_stack_set_instance that deploys to multiple regions in paralell is not yet possible due to hashicorp/terraform-provider-aws#24752, however using the managed-execution flag on the aws_cloudformation_stack_set resources allows multiple aws_cloudformation_stack_set_instance resources to be created in parallel. This has a similar effect, although more objects must be created, potentially neccesitating a higher -parallelism flag on terraform apply.

This PR enables managed-execution for all stacksets created.

Manual testing for a 4 account org, 5 regions, CSPM + EventBridge:

  • TF parallelism=10, managed-execution=false

    • Start: 4:05 (destroy: 4:27)
    • End: 4:27 (destroy: 4:40)
    • Duration: 22m (destroy: 13m)
  • TF parallelism=10, managed-execution=true

    • Start: 4:40 (destroy: 4:46)
    • End: 4:46 (destroy: 4:49)
    • Duration: 6m (destroy: 3m)
  • TF parallelism=100, managed-execution=true

    • Start: 4:50 (destroy: 4:55)
    • End: 4:55 (destroy: 4:57)
    • Duration: 5m (destroy: 2m)

@nkraemer-sysdig nkraemer-sysdig requested review from a team as code owners April 26, 2024 00:04
Copy link
Contributor

@cgeers cgeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 well done.

@nkraemer-sysdig nkraemer-sysdig merged commit 09b230d into main Apr 26, 2024
5 checks passed
@nkraemer-sysdig nkraemer-sysdig deleted the fix/stackset-parallelism branch April 26, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants