Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pbc&al #73

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Pbc&al #73

merged 8 commits into from
Nov 22, 2023

Conversation

Hanwen1018
Copy link
Member

Add PBC option to AL scheme and fix some bugs that cause the code to not work for the condensed phase.

@Hanwen1018 Hanwen1018 requested a review from juraskov November 22, 2023 13:53
juraskov
juraskov approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@juraskov juraskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Before we add it to the main branch we may slightly improve some comments.

@juraskov juraskov merged commit 37bf174 into duartegroup:hanwen/PBC_AL Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juraskov juraskov juraskov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hanwen1018 @juraskov