fix(ts/analyzer): Prevent extra error from being reported from `repor…

…t_error_for_conflicting_parents` (#410)
dudykr · Dec 17, 2022 · acd622f · acd622f
1 parent 22bb3c3
commit acd622f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/crates/stc_ts_file_analyzer/src/analyzer/convert/interface.rs b/crates/stc_ts_file_analyzer/src/analyzer/convert/interface.rs
@@ -102,10 +102,9 @@ impl Analyzer<'_, '_> {
                     ) {
                         match &*err {
                             ErrorKind::MissingFields { .. } => {}
-
                             ErrorKind::Errors { errors, .. }
                                 if errors.iter().all(|err| matches!(&**err, ErrorKind::MissingFields { .. })) => {}
-
+                            ErrorKind::ObjectAssignFailed { .. } => {}
                             _ => self.storage.report(err.convert(|err| ErrorKind::InterfaceNotCompatible { span })),
                         }
                     }

diff --git a/...mance/interfaces/interfaceDeclarations/interfaceWithMultipleBaseTypes.ts.stats.rust-debug b/...mance/interfaces/interfaceDeclarations/interfaceWithMultipleBaseTypes.ts.stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
-    required_error: 4,
-    matched_error: 2,
-    extra_error: 6,
+    required_error: 5,
+    matched_error: 1,
+    extra_error: 0,
     panic: 0,
 }
diff --git a/crates/stc_ts_type_checker/tests/tsc-stats.rust-debug b/crates/stc_ts_type_checker/tests/tsc-stats.rust-debug
@@ -1,6 +1,6 @@
 Stats {
-    required_error: 4269,
-    matched_error: 5615,
-    extra_error: 767,
+    required_error: 4270,
+    matched_error: 5614,
+    extra_error: 761,
     panic: 74,
 }