Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strings should be only mangled when the response type is JSON #473

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Jan 17, 2025

Checklist

  • The code has 100% test coverage.
  • The documentation was properly created or updated (if applicable) following the correct guidelines and appropriate language.
  • I branched out from the latest main or is a sub-branch.

Summary or description

strings should be only mangled when the response type is JSON
Why?

Otherwise when media_type is e.g. text/html, all apostrophes are escaped. I think this is unexpected.
@tarsil what do you think?

Why?

Otherwise when media_type is e.g. text/html, all apostrophes are
replaced
@tarsil
Copy link
Collaborator

tarsil commented Jan 17, 2025

Checklist

  • The code has 100% test coverage.
  • The documentation was properly created or updated (if applicable) following the correct guidelines and appropriate language.
  • I branched out from the latest main or is a sub-branch.

Summary or description

strings should be only mangled when the response type is JSON Why?

Otherwise when media_type is e.g. text/html, all apostrophes are escaped. I think this is unexpected. @tarsil what do you think?

I agree. Somehow that was missed. We can't escape if it's HTML. We introduced this recently in some of the clean up.

@tarsil tarsil merged commit f7b7b0a into main Jan 17, 2025
11 checks passed
@tarsil tarsil deleted the devkral/fixes/string_responses branch January 17, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants