-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️✨♻️ Support bundled transforms #36
Conversation
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 17.32% 18.48% +1.16%
==========================================
Files 44 45 +1
Lines 2211 2229 +18
Branches 365 366 +1
==========================================
+ Hits 383 412 +29
+ Misses 1805 1794 -11
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Interesting the validation of path
- I did not know about the warnings with codecov 👍 . You will achieve 100% coverage in no time :-)
|
||
|
||
def test_validate_args(): | ||
args1 = {"file_path": "/path/file.txt", "arg_int": 10, "arg_float": 5.0} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Why dont' you parametrize these?
When you have to test more variants it will be difficult to check whichone failed
https://docs.pytest.org/en/6.2.x/example/parametrize.html#paramexamples
Something like (please double check) ...
params_data = {
"args1_skip_default": ({"file_path": "/path/file.txt", "arg_int": 10}, False),
"args1_wrong_type": ({"file_path": 23, "arg_int": 10, "arg_float": 5}, True)
}
@pytest.mark.parametrize(
"arguments,expected_failure", list(params_data.values()), ids=list(params_data.keys())
def test_validate_args(arguments, expected_failure):
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Thanks @pcrespov for your review! |
What do these changes do?
This PR implements
bundle.ConfigParser
save_nifti
branch during training, i.e. automatic predicting based on validation dataCropForegroundd
Related issue/s
How to test
Checklist
pytest tests