-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨added cross-validation capabilities #46
Conversation
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 19.48% 20.30% +0.82%
==========================================
Files 47 47
Lines 2392 2531 +139
Branches 395 419 +24
==========================================
+ Hits 466 514 +48
- Misses 1900 1990 +90
- Partials 26 27 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
why don't you write a little test in tests/seg/test_dataset.py to make sure the dataset kfold splitting is doing what you expect? Ps. the magic variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good now.
- Please avoid the code duplication marked in dataset.py
- and check that training and cross-validate run properly.
- also add a check that the (training/validation) files in the dataset actually exist and are not just globs (in the modified test).
LGTM |
What do these changes do?
The changes should enable the user to run a cross validation. At the moment it is with the old implementation style using
.json files. Will need to adapt the code to work with the newer .yamal files instead.
Related issue/s
How to test
Checklist