[app][git] current dir is removed from base path

- the default clone behaviour does not require destination, so just an
  empty string is enough

app/git/README.md

@@ -12,6 +12,6 @@ It can do the following:
 - [x] support default http clone url in `remote.go`'s `NewFromURL`
 - [x] support default ssh clone url in `remote.go`'s `NewFromURL`
 - [x] handle non default ssh port in `GetSSH`
-- [x] detect workspace, config -> gopath -> ~~askuser input~~ current dir and clone to workspace
+- [x] detect workspace, config -> gopath -> ~~askuser input~~ ~~current dir~~ and clone to workspace
 - [ ] clone project by host order if using short url, and let user choose if there are same project on multiple hosts 
 - [ ] cleanup duplicated code `remote.go`, all the checking and error logging can be merged

app/git/clone.go

@@ -15,6 +15,6 @@ func CloneFromURL(repoURL string) error {
 // Clone clones a remote git repo
 func Clone(r Remote) error {
 	log.Info(r.GetSSH())
-	log.Info("git clone " + r.GetSSH())
+	log.Info("git clone " + r.GetSSH() + " " + GetRepoBasePath() + "/" + r.Repo)
 	return nil
 }

app/git/workspace.go

@@ -19,11 +19,5 @@ func GetRepoBasePath() string {
 	if gopath != "" {
 		return filepath.FromSlash(gopath + "/src")
 	}
-	// use current folder as repo base path
-	cwd, err := os.Getwd()
-	if err != nil {
-		log.Warn("Can't get working directory " + err.Error())
-		return ""
-	}
-	return cwd
+	return ""
 }

app/git/workspace_test.go

@@ -29,9 +29,5 @@ func TestGetRepoBasePath(t *testing.T) {
 	viper.Set("git.repositories", "")
 	os.Setenv("GOPATH", p)
 	assert.Equal(filepath.FromSlash(p+"/src"), GetRepoBasePath())
-	// current dir is used if both config file and gopath are not set
-	os.Setenv("GOPATH", "")
-	cwd, _ := os.Getwd()
-	assert.Equal(cwd, GetRepoBasePath())
 
 }