-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indicator map to area impact view #90
Conversation
Changes added:
Quick demo: How to give feedback:
The transition of production->transport area view is displaying all the destination areas, but I couldn't find what is causing the issue yet. I suggest we ticket in separate if this is not blocking. @wrynearson this is ready for a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a bug when selecting a second producing area while in the impact on people
view from a first producing area – the first impact on geometries are shown on the impacts from the second. @vgeorge and I discussed this just now.
@wrynearson I added a change to address the issue you found. I also included an empty state to make it clear when no flows are available for an area (contributes to #85). It says "Go to World View" instead of the Figma design’s "Go back" because the user might be accessing the area URL directly, so there may be no browser history to return to. I won't be adding more features to this PR, this is ready for a final review. |
@wrynearson and I reviewed this together and decided that it is ready to merge. |
Contributes to #20. This is work in progress.
In this PR we aim to add a choropleth map of the population impacted by the producing area. Other indicators will be implemented in separate tickets as enhancements.
Changes added:
totalpop
parameter in vector tiles and single area API endpoints<AreaLayer/>
componentKnown issues:
Screen capture:
cc @wrynearson @faustoperez