fixing off by 1 error -- and adding unit test

earth-genome · Jan 9, 2025 · 8f8417d · 8f8417d
1 parent 7527f32
commit 8f8417d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/majortom/mtgrid.go b/majortom/mtgrid.go
@@ -146,7 +146,7 @@ func (g *MajorTomGrid) CellFromId(id string) (*GridCell, error) {
 
 	searchId := id
 	if len(id) > geohashPrecision {
-		searchId = id[0 : geohashPrecision-1]
+		searchId = id[0:geohashPrecision]
 	}
 
 	box, err := geohash.Decode(searchId)

diff --git a/majortom/mtgrid_test.go b/majortom/mtgrid_test.go
@@ -311,8 +311,15 @@ func TestOddTile(t *testing.T) {
 	g := NewGrid(320, true)
 	cell, err := g.CellFromId("qr330j8p802")
 	if err != nil {
-		t.FailNow()
+		t.Fail()
 	} else {
 		t.Logf("Expected: qr330j8p802, Got: %s", cell.Id())
 	}
+	cell, err = g.CellFromId("gcp0ywcrhk1t24vzxu52")
+	if err != nil {
+		t.Fail()
+	} else {
+		t.Logf("Expected: gcp0ywcrhk1, Got: %s", cell.Id())
+	}
+
 }