forked from OSGeo/grass
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checks: Pylint 3 remaining #328
Open
echoix
wants to merge
24
commits into
main
Choose a base branch
from
pylint-3-remaining
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
force-pushed
the
pylint-3-remaining
branch
3 times, most recently
from
December 27, 2024 00:57
1bfb461
to
fd4a0ec
Compare
echoix
force-pushed
the
pylint-3-remaining
branch
2 times, most recently
from
December 28, 2024 00:36
aebe821
to
119a673
Compare
…orts There is no reason (dependency of imports) apparent here that would prevent it from working. Works locally in a Ubuntu 22.04 WSL on Windows
grass.script was already below gui imports in 2023
This allows static analysis of self.render dict, that contains 4 keys and all boolean values
Rename index argument to type
Includes using different aliases for different type of ids, to be able to check for usage mismatches
gui.wxpython.nviz.wxnviz: Add some type hints for Texture and ImageTexture
…ectors, considered tuples
When results of GetPointOnSurface() is None, ensure that we return None, and the other branch is assured to contain floats
… None or other variables are missing
echoix
force-pushed
the
pylint-3-remaining
branch
from
December 31, 2024 14:23
119a673
to
cf72edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.