Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Pylint 3 remaining #328

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

checks: Pylint 3 remaining #328

wants to merge 24 commits into from

Conversation

echoix
Copy link
Owner

@echoix echoix commented Dec 27, 2024

No description provided.

@echoix echoix force-pushed the pylint-3-remaining branch 3 times, most recently from 1bfb461 to fd4a0ec Compare December 27, 2024 00:57
@echoix echoix force-pushed the pylint-3-remaining branch 2 times, most recently from aebe821 to 119a673 Compare December 28, 2024 00:36
…orts

There is no reason (dependency of imports) apparent here that would prevent it from working.

Works locally in a Ubuntu 22.04 WSL on Windows
grass.script was already below gui imports in 2023
This allows static analysis of self.render dict, that contains 4 keys and all boolean values
Includes using different aliases for different type of ids, to be able to check for usage mismatches
gui.wxpython.nviz.wxnviz: Add some type hints for Texture and ImageTexture
When results of GetPointOnSurface() is None, ensure that we return None, and the other branch is assured to contain floats
@echoix echoix force-pushed the pylint-3-remaining branch from 119a673 to cf72edb Compare December 31, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant