Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#224] remove obsolete tm4e Cpp content type binding #226

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

ghentschke
Copy link
Contributor

Since this eclipse-tm4e/tm4e#500 lsp4e issue has been closed by this platform fix:
eclipse-platform/eclipse.platform#151 we can now remove the contentTypeBinding to the lsp4e C++ content type definition.

fixes #224

@ghentschke ghentschke requested a review from jonahgraham January 7, 2024 08:37
@ghentschke ghentschke changed the title [#224] remove obsolete lsp4e Cpp content type binding [#224] remove obsolete tm4e Cpp content type binding Jan 7, 2024
Since this eclipse-tm4e/tm4e#500 lsp4e issue has been
closed by this platform fix:
eclipse-platform/eclipse.platform#151 we can
now remove the contentTypeBinding to the lsp4e C++ content type
definition.

fixes eclipse-cdt#224
Copy link
Member

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghentschke for coming back and fixing this up now that eclipse-platform/eclipse.platform#151 is released.

@ghentschke ghentschke merged commit 84fd92c into eclipse-cdt:master Jan 11, 2024
2 checks passed
@ghentschke ghentschke deleted the fix-issue-224 branch January 12, 2024 07:38
@trancexpress
Copy link

Hi all,

we see a start-up error in our Eclipse installation:

Plugin org.eclipse.cdt.lsp, extension org.eclipse.ui.editors: Unknown content-type with id: lng.cpp

It seems that this PR was merged and we have a corresponding tm4e in our installation: eclipse-tm4e/tm4e#500

When can we expect a release of cdt-lsp that has the PR here included? So that we don't see the start-up error.

Best regards and thanks,
Simeon

@ghentschke
Copy link
Contributor Author

Hi,
I would like the open PR #227 to be in the next release. The we can do a release. What do you think @jonahgraham ? I think end of this week or next week sounds realistic to me.

@ghentschke ghentschke added this to the 1.1.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown content-type with id: lng.cpp
4 participants