[#381] use only system dependent line separator as seprator #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...for clangd options. And no spaces anymore, because they lead to trouble when file path used in options contains spaces. fixes eclipse-cdt#381
jonahgraham
reviewed
Dec 12, 2024
| @@ -72,7 +72,7 @@ public List<String> additionalOptions() { | |||
| if (options.isBlank()) { | |||
| return new ArrayList<>(); | |||
| } | |||
| return Arrays.asList(options.split("\\s+")); //$NON-NLS-1$ | |||
| return Arrays.asList(options.split(System.lineSeparator())); | |||
There was a problem hiding this comment.
Minor observation is that on Windows this won't split \n separated options anymore. Should this be split on "\r?\n" (not sure if escaping is correct, but I hope you understand my meaning?)
There was a problem hiding this comment.
You're right. The originally implementation used \R in the regex. This might be the better implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...for clangd options. And no spaces anymore, because they lead to trouble when file path used in options contains spaces.
fixes #381