Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "C/C++ editor (LSP)" documentation content #385

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jld01
Copy link
Contributor

@jld01 jld01 commented Dec 13, 2024

Relates to eclipse-cdt/cdt#963

@jld01 jld01 force-pushed the lsp-editor-doc branch 2 times, most recently from 5464426 to f9a2ce7 Compare December 13, 2024 22:03
@jld01 jld01 self-assigned this Dec 13, 2024
@jld01 jld01 changed the title Add "C/C++ editor (LSP)" documentation page content Add "C/C++ editor (LSP)" documentation content Dec 14, 2024
@jonahgraham
Copy link
Member

Looks good so far. Thanks @jld01

Copy link
Contributor

@ghentschke ghentschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghentschke
Copy link
Contributor

@jld01 Thank you!

@jld01 jld01 force-pushed the lsp-editor-doc branch 2 times, most recently from 84706c5 to b352adf Compare December 17, 2024 20:47
@jld01 jld01 marked this pull request as ready for review December 17, 2024 20:49
@jld01
Copy link
Contributor Author

jld01 commented Dec 17, 2024

I think this is a good point at which to merge the initial content.

@ghentschke ghentschke merged commit 2bc7c76 into eclipse-cdt:main Dec 18, 2024
3 checks passed
@jld01 jld01 deleted the lsp-editor-doc branch December 21, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants