-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions to support shm #125
base: master
Are you sure you want to change the base?
Extensions to support shm #125
Conversation
The initial changes are taken from e-hndrks - fixes eclipse-cyclonedds#84 Signed-off-by: Sumanth Nirmal <[email protected]>
- Fixes eclipse-cyclonedds#84 Signed-off-by: Sumanth Nirmal <[email protected]>
- Set the fixed size mask in flags during the creation of sertype - Set the iox_size to sample size during the creation of sertype - Fixes eclipse-cyclonedds#84 Signed-off-by: Sumanth Nirmal <[email protected]>
- Fixes eclipse-cyclonedds#84 Signed-off-by: Sumanth Nirmal <[email protected]>
- fixes eclipse-cyclonedds#84 Signed-off-by: Sumanth Nirmal <[email protected]>
Signed-off-by: Sumanth Nirmal <[email protected]>
Signed-off-by: Sumanth Nirmal <[email protected]>
Signed-off-by: Sumanth Nirmal <[email protected]>
…lization required Signed-off-by: Sumanth Nirmal <[email protected]>
@e-hndrks methinks this unintentionally includes various commits and needs to be rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe have some larger messages in the example program to better illustrate the performance improvements?
{ | ||
struct Msg | ||
{ | ||
long data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is enough to just have this small of a message?
Maybe it is better to have a message with a huge payload to better illustrate the performance increase iceoryx can cause?
@@ -69,6 +69,10 @@ class dds::pub::detail::DataWriter : public ::org::eclipse::cyclonedds::pub::Any | |||
|
|||
void init(ObjectDelegate::weak_ref_type weak_ref); | |||
|
|||
T& loan_sample(); | |||
|
|||
void return_loan(T& sample); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not overlap with @e-hndrks work on the loan interface?
Hi @eboasson , the reason why this is not a stand-alone Pull Request is that it builds on top of the changes that have already been made for the loan_sample API, which is therefore a prerequisite for this PR. However, the loan_sample API is currently part of a PR from @sumanth-nirmal, which hasn't been accpeted yet. For that reason, I started from his working branch. |
No description provided.