Update PyCDR packaging strategy #4
Conversation
| Bug Tracker = https://github.com/eclipse-cyclone/cyclonedds-python/issues | ||
| classifiers = | ||
| Development Status :: 4 - Beta | ||
| License :: OSI Approved :: Eclipse Public License 2.0 (EPL-2.0) |
There was a problem hiding this comment.
Shouldn't EDLv1 be mentioned as well?
There was a problem hiding this comment.
It really should, but it is not in the officially supported classifier list. I am looking into how to get it on there.
There was a problem hiding this comment.
I wonder if you cannot just use BSD-3-Clause instead? It's the same license and that's what we mention in the headers(?)
There was a problem hiding this comment.
SPDX-License-Identifier: EPL-2.0 OR BSD-3-Clause that's what's in the top of our headers...
There was a problem hiding this comment.
The full list is here, BSD-3 is also not on there. I am wondering, since these classifiers are just strings, if I can just add new ones. I will run a test on the test-pypi website.
There was a problem hiding this comment.
I found instructions in the Pypi FAQ and filed an issue here for it to be added.
There was a problem hiding this comment.
The Eclipse Distribution License is an OSI Approved Open Source License by means of the New BSD License ([as stated on the Eclipse Foundation website](The Eclipse Distribution License is an OSI Approved Open Source License by means of the New BSD License)). You can probably just go with "BSD"(?) as the OSI identifies "BSD-3-Clause" and "BSD-2-Clause". Perhaps BSD covers both(?). Seems more people have this problem: PEP 639. I'd just use BSD 3-Clause "New" or "Revised" License (BSD-3-Clause)
The general consensus is to move away from running code as part of the installation process, which is why we get binary wheels for more complex packages and this setup.cfg stuff for simple python-only packages. |
|
@thijsmie any idea how long it will take for the BSD 3-Clause license to get added to the classifier list? If it is going to take much longer, perhaps there's another way to indicate this possibility in a free-form note somewhere and simply have the main license be EPL2. |
|
No activity from Pypi maintainers on the issue so far, not even "you can submit a pull request with this change". Shall I just add the "BSD" classifier with a comment that BSD-Clause-3 is intended? |
Bummer ... so
Let's do that. |
PyCDR does not need any complicated setup so this PR updates it to use the newer
setup.cfgmethod.setup.pyis still present as empty shell to allow older (v18 and below) pip distributions to still use the installer.