Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Eclipse.icns to match Apple UI Guideline #77

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

BeckerWdf
Copy link
Contributor

@BeckerWdf
Copy link
Contributor Author

@jonahgraham: Can you pls. review?

@jonahgraham
Copy link
Contributor

@BeckerWdf thanks for this fix.

As this applies this releasing.md step you have saved me some time by applying it yourself. Thank you!

- [ ] Synchronize any changes to [platform's icons'](https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/icons) into `icons` root directory.

@jonahgraham jonahgraham merged commit b81ff4b into eclipse-packaging:master Nov 7, 2023
11 checks passed
@jonahgraham
Copy link
Contributor

In a few hours a new build (still called M2 because I haven't done the other steps of #79 yet) will be published to https://download.eclipse.org/technology/epp/staging/ if you can test it out to make sure it looks as expected on mac.

@BeckerWdf
Copy link
Contributor Author

In a few hours a new build (still called M2 because I haven't done the other steps of #79 yet) will be published to https://download.eclipse.org/technology/epp/staging/ if you can test it out to make sure it looks as expected on mac.

Sure. I can test that. Just ping me once it's available.

@BeckerWdf
Copy link
Contributor Author

In a few hours a new build (still called M2 because I haven't done the other steps of #79 yet) will be published to https://download.eclipse.org/technology/epp/staging/ if you can test it out to make sure it looks as expected on mac.

Sure. I can test that. Just ping me once it's available.

I just tested with eclipse-committers-2023-12-M2-macosx-cocoa-aarch64.tar.gz. It looks good:
image

@jonahgraham
Copy link
Contributor

Thanks for reporting back that it looks good.

@BeckerWdf BeckerWdf deleted the macOS_icon branch November 15, 2023 12:24
@BeckerWdf
Copy link
Contributor Author

just had a loot at it on the final 2023-12 EPPs. It is fixed.

@jonahgraham
Copy link
Contributor

Thanks @BeckerWdf for fixing this and tracking it through all the way to release!

@jonahgraham jonahgraham mentioned this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] Update Eclipse.icns to match Apple UI Guideline
2 participants