-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Eclipse.icns to match Apple UI Guideline #77
Conversation
@jonahgraham: Can you pls. review? |
@BeckerWdf thanks for this fix. As this applies this releasing.md step you have saved me some time by applying it yourself. Thank you! Line 49 in 278d8d4
|
In a few hours a new build (still called M2 because I haven't done the other steps of #79 yet) will be published to https://download.eclipse.org/technology/epp/staging/ if you can test it out to make sure it looks as expected on mac. |
Sure. I can test that. Just ping me once it's available. |
I just tested with eclipse-committers-2023-12-M2-macosx-cocoa-aarch64.tar.gz. It looks good: |
Thanks for reporting back that it looks good. |
just had a loot at it on the final 2023-12 EPPs. It is fixed. |
Thanks @BeckerWdf for fixing this and tracking it through all the way to release! |
Fixes: eclipse-platform/eclipse.platform.ui#1247