HTTP client timeout improvements #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts can be ran with domain sockets
vietj
force-pushed
the
http-client-timeout-4.x
branch
from
7e5341b to
efe9142
Compare
This was referenced Nov 9, 2023
vietj
force-pushed
the
http-client-timeout-4.x
branch
7 times, most recently
from
ba25f15 to
de0cd77
Compare
… It acts both as a connect and idle timeout. Introduce separate connect and idle timeouts for HTTP client, the connect timeout fires when a request has not been obtained from the pool in time, the idle timeout is a rename of the existing timeout (on HttpClientRequest). RequestOptions deprecates the timeout property and introduces a connect timeout and an idle timeout. To achieve the same effect both connect/idle timeouts can be set. HttpClientRequest deprecates the setTimeout method in favor of setIdleTimeout which is a better and explicit name.
…nteed result within a time limit. When the timeout fires, the future is failed with a TimeoutException.
vietj
force-pushed
the
http-client-timeout-4.x
branch
from
de0cd77 to
0458aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way HTTP client timeouts does not meet all the expectations.
The
timeoutpresent onRequestOptionsapplies for the time to obtain a connection and then configures the idle timeout of the request.We should add to
RequestOptionsaconnectTimeoutapplied when a request is obtained from the client pool and anidleTimeoutapplied to theHttpClientRequestafter it has been obtained from the pool, to configure timeouts separately when necessary.HttpClientRequestnow has asetIdleTimeoutmethod which is a bare rename ofsetTimeoutand better carries the meaning of the method.In addition it should be easier to define a global timeout when interacting with an HTTP server that is not captured by connect or idle timeout. The
Futureinterface now has atimeoutmethod allowing to define a timeout when obtaining a result, e.g. the result of an HTTP client interaction with a server.