JsonArray optimizations #4995
JsonArray optimizations #4995
Conversation
magicprinc
commented
Dec 2, 2023
magicprinc
commented
- Better stream() and spliterator() implementations
- ctor with initialCapacity
- better copy ctor
1) use JDK Map.entry(key,value) instead of self-made Entry class One caveat: Map.entry disallows null keys and values (Attempts to create Map.Entry using a null key or value result in NullPointerException) 2) (Linked)HashMap has DEFAULT_LOAD_FACTOR = 0.75f: if you create it with initialCapacity=X and put X items into it then HashMap resizes (with new internal array allocation and re-hash). One has to create HashMap with initialCapacity=X/0.75 e.g. for 10 keys initialCapacity must be at least 14 3) better inheritance: equals `if (getClass() != o.getClass()) return false;` rejects subclasses. if (!(o instanceof JsonObject)) return false allows subclasses and checks for null
1) use MAP_CREATOR 2) LinkedHashMap → HashMap (can be changed in MAP_CREATOR) 3) better initial capacity
better spliterator() and stream() implementations Use Spliterator flags and map.size() to make them more performant
|
can you provide a single commit PR ? if you need 10 commits for a PR then just do the 10 commits in your branch (that is your concern, not ours) and then do a PR once you believe the PR is ready with a single commit. |
| /** | ||
| * Create an instance from a List. The List is not copied. | ||
| * | ||
| * @param list the underlying backing list | ||
| */ | ||
| public JsonArray(List list) { | ||
| if (list == null) { | ||
| @SuppressWarnings({"rawtypes", "unchecked"}) |
There was a problem hiding this comment.
that is an avoidable breaking change, we need to keep the List constructor
There was a problem hiding this comment.
Does it really break?
I just thought widening is not a problem 🤷♀️
|
why this PR is also applying what your other PR about json object contains ? we are not going to review the same code twice. |
|
in other words this PR seems to be focusing on JsonArray, it should not care about JsonObject unless there is a relationship |
|
@vietj I have made branch from feature/jsonObject just in haste 😥 I will redo this PR as a single commit with JsonArray only. |
|
I close this PR, sorry, no time for rebase and force-push - deadline at job. |
