-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support zstd compression #5176
support zstd compression #5176
Conversation
30ae343
to
205fe91
Compare
can you create a test for this based on a subclass of HttpCompressionTestBase like other compression schemes have ? |
@sullis test is not passing, can you investigate ? |
I believe we need to wait for Netty 4.1.109. The Netty team recently updated HttpContentDecompressor, and the change will be included in the 4.1.109 release. I am going to convert this PR to "draft" for now. |
in my local workspace, I upgraded to a Netty snapshot release ( Netty 4.1.109.Final-SNAPSHOT). Http1xZstdCompressionTest passes with the Netty snapshot. |
ok then it's in standby for now |
@sullis can you update the PR since now vertx depends on Netty 4.1.109.Final ? |
9dde854
to
4777620
Compare
Awesome! I just pushed an update. Let's wait for the CI build to finish 😎 |
CI build looks good. |
Motivation
Netty supports zstd compression.
Google Chrome recently added support for zstd
https://www.phoronix.com/news/Zstd-1.5.6-Zstandard
Conformance
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines