The kube resolver should set the endpoints when the subsets json structure is not present #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture is not present. Motivation: The kube resolver sets the list of endpoints (pods) from the subsets member of the endpoints json object. When the service does not have any pods, the subsets member is absent and causes an NPE downstream in the resolver assuming the endpoints list is never null. Changes: Always set the list of endpoints to consistently populate the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The kube resolver sets the list of endpoints (pods) from the subsets member of the endpoints json object.
When the service does not have any pods, the subsets member is absent and causes an NPE downstream in the resolver assuming the endpoints list is never null.
Changes:
Always set the list of endpoints to consistently populate the list.