Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins/frustum_culling: Add frustum culling plugin #240

Merged
merged 1 commit into from
May 6, 2024
Merged

plugins/frustum_culling: Add frustum culling plugin #240

merged 1 commit into from
May 6, 2024

Conversation

mats4
Copy link
Contributor

@mats4 mats4 commented Apr 30, 2024

No description provided.

@mats4 mats4 requested review from cassava and tobifalk as code owners April 30, 2024 07:11
@mats4 mats4 force-pushed the feature/ADASXIL-854-add-frustum-culling-plugin branch from 5867d5b to a94455d Compare April 30, 2024 07:27
@cassava cassava changed the title plugins/frustum_culling: Add frustum culling plugin. ADASXIL-854. plugins/frustum_culling: Add frustum culling plugin Apr 30, 2024
cassava
cassava requested changes Apr 30, 2024
View reviewed changes
plugins/frustum_culling/src/frustum_culling_conf.hpp Outdated Show resolved Hide resolved
plugins/frustum_culling/.vscode/launch.json Outdated Show resolved Hide resolved
plugins/frustum_culling/.gitignore Outdated Show resolved Hide resolved
plugins/frustum_culling/readme.md Outdated Show resolved Hide resolved
@mats4 mats4 force-pushed the feature/ADASXIL-854-add-frustum-culling-plugin branch from a94455d to 2a93e4b Compare April 30, 2024 13:26
@mats4 mats4 requested a review from cassava April 30, 2024 13:34
cassava
cassava approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@cassava cassava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are a few minor points that could still be addressed, and we need to see why CI is failing the ESMini build.

models/src/cloe/utility/frustum_culling_test.cpp Outdated Show resolved Hide resolved
plugins/frustum_culling/src/frustum_culling_conf.hpp Show resolved Hide resolved
@mats4 mats4 force-pushed the feature/ADASXIL-854-add-frustum-culling-plugin branch from 44b4eef to eeff97b Compare May 6, 2024 05:36
@cassava cassava merged commit 9f921ec into eclipse:master May 6, 2024
4 checks passed
@cassava cassava added this to the 0.24.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassava cassava cassava approved these changes

@tobifalk tobifalk Awaiting requested review from tobifalk tobifalk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mats4 @cassava