service-mesh: blackhole traffic destined for the TPROXY port #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
3u13r
commented
Jan 21, 2025
•
3u13r
commented
- blackhole traffic that would cause the envoy to infinitely connect to itself
- add tests for the envoy config
3u13r
force-pushed
the
euler/fix/service-mesh/blackhole-direct-tproxy-traffic
branch
from
ac085b5 to
47b9850
Compare
3u13r
changed the title
3u13r
force-pushed
the
euler/fix/service-mesh/blackhole-direct-tproxy-traffic
branch
from
47b9850 to
b62d878
Compare
Traffic to the TPROXY port (15006/15007) led to a traffic storm as envoy used the original destination to forward the traffic to, therefore forwarding it again to the TPROXY port where envoy listens. This commit introduces a Blackhole cluster where we send traffic to, that arrives on the TPROXY listeners and which original destination port is the TPROXY.
3u13r
force-pushed
the
euler/fix/service-mesh/blackhole-direct-tproxy-traffic
branch
from
b62d878 to
85a7740
Compare
With increasing envoy config complexity it gets more difficult to parse the final envoy config. Therefore we introduce tests which compare the envoy config for specific scenarios with golden JSON representations of the expected output.
3u13r
force-pushed
the
euler/fix/service-mesh/blackhole-direct-tproxy-traffic
branch
from
85a7740 to
5a6afdd
Compare
burgerdev
reviewed
Jan 23, 2025
| continue | ||
| } | ||
| if len(listener.FilterChains) != 1 { | ||
| return fmt.Errorf("listener %s doesn't has exactly one existing listener", listener.Name) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("listener %s doesn't has exactly one existing listener", listener.Name) | |
| return fmt.Errorf("listener %s doesn't have exactly one existing listener", listener.Name) |
| if listenPort == 0 { | ||
| return fmt.Errorf("listener %s listens on port 0", listener.Name) | ||
| } | ||
| if listenPort != 15006 && listenPort != 15007 { |
There was a problem hiding this comment.
Can we make these arguments and use constants where we're calling addBlackHoleToConfig? That'd allow easier customization later on - I've been wondering lately when we'll have the first user that wants these ports for their app :)
Comment on lines
+451
to
+455
| // Blackhole traffic that arrives on the original destination listerners, | ||
| // which original port is the envoy itself, i.e. traffic that was not redirected | ||
| // to the envoy via the TROXY iptables rule. Such traffic would lead to a | ||
| // traffic storm since envoy would connect to the original destination | ||
| // i.e. itself again. |
There was a problem hiding this comment.
Please add a sentence that explains how the traffic is blackholed - is it because there is no upstream in the cluster?
Comment on lines
+44
to
+46
| func TestMain(m *testing.M) { | ||
| goleak.VerifyTestMain(m) | ||
| } |
There was a problem hiding this comment.
Did you introduce this for a specific reason? This binary looks pretty serial...
There was a problem hiding this comment.
No, I thought we would just add this per convention for new tests, since e.g.,
contrast/internal/fsstore/fsstore_test.go
Line 17 in 5a6afdd
There was a problem hiding this comment.
I don't, was just curious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.