Implement missing math functions in LLVM backend #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiribenes
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Hi @mattisboeckle, thanks for the great first contribution!
I have a few maintenance discussion topics below -- even though the contribution is great and already mergeable, it would be nice to make sure that the definitions we want to use are maintainable in the future. I'm interested in your opinion as to how we should act regarding the more complex functions / constants that are not available directly as intrinsics before we proceed :)
mattisboeckle
force-pushed
the
fix/llvm-missing-math
branch
from
3979a04 to
1dfcaf1
Compare
mattisboeckle
force-pushed
the
fix/llvm-missing-math
branch
3 times, most recently
from
43ee27b to
2e316ec
Compare
jiribenes
reviewed
Jan 10, 2025
Implement cos, sin, atan, tan, log, log1p, _pi, exp & pow. All functions use the LLVM intrinsics except tan & atan. They do not exist in the version of LLVM we are using. Fixes effekt-lang#608
mattisboeckle
force-pushed
the
fix/llvm-missing-math
branch
from
2e316ec to
b464321
Compare
jiribenes
approved these changes
Jan 14, 2025
EveEme
pushed a commit
to EveEme/effekt
that referenced
this pull request
Jan 20, 2025
Implement cos, sin, atan, tan, log, log1p, _pi, exp & pow. All functions use the LLVM intrinsics except tan & atan. They do not exist in the version of LLVM we are using. Fixes effekt-lang#608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement cos, sin, atan, tan, log, log1p, _pi, exp & pow. All functions use the LLVM intrinsics except tan & atan. They do not exist in the version of LLVM we are using.
Fixes #608