-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stdlib test importing every stdlib module + fix stdlib #795
Conversation
|
Note Moved to #801 New LLVM bugs, cc @phischu:
EDIT: I think it's the same problem, actually.
which always share what would be:
so the same value is defined under the same name in multiple different functions. |
val result: T = contents.remove(head).getOrElse { <> }; | ||
val result: T = contents.unsafeGet(head); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is semantically correct, we use it as a circular buffer, so we don't really need to invalidate the previous value -- we'd have overwritten it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this since it's a change that I really want in the next release, any nitpicks can be fixed in a separate PR
Resolves #614 by adding a stdlib test that imports every single (common) stdlib module.
Let's add ACME (in our context "All Common Modules in Effekt" :)) to the stdlib tests: just import and compile all modules.
This revealed 3 different bugs in stdlib + codegen bugs on LLVM (moved to #801).