Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New app icon #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New app icon #5

wants to merge 2 commits into from

Conversation

Xorok
Copy link

@Xorok Xorok commented Oct 30, 2016

No description provided.

@Xorok
Copy link
Author

Xorok commented Oct 31, 2016

Here is a link with the different resolutions & .svg's:
https://1drv.ms/f/s!AvyTnKj7K3GNpmT2eGTe_3_YH6z2

@M1cha
Copy link
Member

M1cha commented Nov 4, 2016

can you rebase this?

@Xorok
Copy link
Author

Xorok commented Nov 4, 2016

It was actually an accident, I didn't plan to add those commits to the pull request. The log is a mess :/

Xorok pushed a commit to Xorok/android_app_efidroidmanager that referenced this pull request Nov 4, 2016
@M1cha
# This is a combination of 26 commits.
d0ee30c 
# The first commit's message is:

allow changing OTA url using efidroid.server_url

# This is the commit message #2:

busybox: enable truncate

# This is the commit message #3:

RootToolsEx: createLoopImage: use truncate

# This is the commit message efidroid#4:

OSUpdateProgressServiceTask: fix error message

# This is the commit message efidroid#5:

update gradle to version 2.2.0

# This is the commit message efidroid#6:

update library and build tools versions

# This is the commit message efidroid#7:

gitignore: update from android studio

# This is the commit message efidroid#8:

update version code to 2

# This is the commit message efidroid#9:

fix ArrayIndexOutOfBoundsException while parsing mountinfo

# This is the commit message efidroid#10:

busybox: enable CONFIG_LFS

# This is the commit message efidroid#11:

update gradle to 2.2.1

# This is the commit message efidroid#12:

update build tools to 24.0.3

# This is the commit message efidroid#13:

make backup of firmware partition instead of creating an empty one

# This is the commit message efidroid#14:

improve error reporting for root commands

# This is the commit message efidroid#15:

update version code to 3

# This is the commit message #16:

MountEntry: add getMountOptionsList

# This is the commit message #17:

OperatingSystemEditActivity: hide readonly filesystems

# This is the commit message #18:

add LICENSE

# This is the commit message #19:

remove ostype 'Ubuntu' from the list

# This is the commit message #20:

update gradle to 2.2.2

# This is the commit message #21:

Add new app icon

# This is the commit message #22:

Add new vector icon for about screen

# This is the commit message #23:

Library & build tool updates

# This is the commit message #24:

Changed volley library source

# This is the commit message #25:

Enable ProGuard code & resource shrinking to reduce apk size by 1/3

# This is the commit message #26:

Automatic changes
@Xorok Xorok force-pushed the master branch 2 times, most recently from fd70640 to 54152d8 Compare November 4, 2016 19:05
@Xorok
Copy link
Author

Xorok commented Nov 4, 2016 •
edited
Loading

Ok, thanks to @z3ntu, this pull request now only contains the new app icon again :)
I'll create a new PR for the other changes.

@M1cha
Copy link
Member

M1cha commented Nov 4, 2016

I'll not merge this yet though since I didn't get an answer from uefi.org yet and you said yourself that you have a much better icon idea.

@M1cha
Copy link
Member

M1cha commented Nov 9, 2016 •
edited
Loading

Unfortunately, the group agreed that the way the UEFI logo is displayed here is not in accordance with the UEFI Forum’s approved Logo Usage Guidelines and dilutes the UEFI brand when combined with other logos. The inverted UEFI logo (red lettering and white cube) is not consistent with the PMS color guidelines, as the logo may only be used and printed in PMS 032u, or in black and white when appropriate. Also, overlaying the UEFI logo on top of the Android robot is in violation of the clear space requirement for the UEFI logo.

Instead, you could consider aligning the UEFI logo and Android logo side-by-side or vertically on top of the UEFI logo with spacing. Please let us know if you come up with additional formats you would like us to review.

I answered, that we're working on a different logo. I'll wait until you update this pull request with a new logo then :)

@M1cha M1cha added the invalid label Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xorok @M1cha