Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eic-spack contribution guidelines #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahmans1
Copy link
Contributor

Briefly, what does this PR introduce?

Adds guidelines on how to add new python packages to eic-shell environment

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@rahmans1 rahmans1 requested review from veprbl and wdconinc January 14, 2025 14:50

**Q: How do I make new python packages available in eic-shell container environment?**

A user might need to add a new python package or update the version of a package available in the eic-shell container. The following steps would be needed:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limit the statement to just new packages since that's what the instructions are focused on. Updated versions are easier (even if steps 3 and 4 are similar). Maybe add a next Q on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants