Avoid modification of https.protocols #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables TLSv1.3 and changes global state that shouldn't be changed. Fixes eirslett#1170.
|
The AppVeyor build doesn't seem active in this PR, so not sure whether it still works without the config option or not. |
|
LGTM. Did you test it locally with your TLS1.3 setup? |
|
@pitgrap I haven't, yet, need to build a release for that locally. But now it's merged anyway, will test the next release then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables TLSv1.3 and changes global state that shouldn't be changed.
Fixes #1170.