Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script][combat-trainer] make aiming_trainables stop attacking if locked/close to lock #7062

Merged

Conversation

mdr55
Copy link
Contributor

@mdr55 mdr55 commented Jan 18, 2025

Aiming_trainables have a tendency to lock early due to low RTs + being able to be off-handed. The current behaviour is that even if the aiming_trainable is locked, it will continue to be used, and have a significant chance of "kill-stealing" from the loadable weapon, with no benefit.

The check introduced here will stop the aiming_trainable if its (near-) locked and give the loadable weapon a chance to fire. This should work where the aiming_trainable and the loadable weapon competing for kills are close-ish in rank. Conversely if an overskilled aiming_trainable is used in a backhunt, the dabbling MS will not trigger the check; CT will continue to spam the dabbling aiming_trainable in that case (which will never lock due to nature of backhunt - same as main hand weapons).

Don't believe we need a yaml switch for this, the change should become the new default behaviour?

@mdr55
Copy link
Contributor Author

mdr55 commented Jan 18, 2025

  • Awkwardly, a granite gargoyle pounds at you. You partially block with a lumium round sipar.
    [You're adeptly balanced and in superior position.]

You feel fully attuned to the mana streams again.

[combat-trainer]>aim

  • Looking as if this were a bad idea, a granite gargoyle pounds at you. You partially block with a lumium round sipar.
    [You're adeptly balanced and overwhelming your opponent.]

You begin to target a granite gargoyle.

[combat-trainer]>gouge left
< Driving in with exacting precision, you gouge your fingers at a granite gargoyle. A granite gargoyle attempts to evade, stepping partly into the blow. The fingers lands a good strike to the gargoyle's chest.
[You're incredibly balanced and overwhelming opponent.]
[Roundtime 1 sec.]

[combat-trainer]>gouge left
< Driving in like the overwhelming force of a hurricane, you gouge your fingers at a granite gargoyle. A granite gargoyle attempts to evade, stepping partially into the shot. The fingers lands a solid hit to the gargoyle's back.
[You're incredibly balanced and overwhelming opponent.]
[Roundtime 1 sec.]

what happens currently & in the PR before the brawling aiming_trainable gets to 34

@mdr55
Copy link
Contributor Author

mdr55 commented Jan 18, 2025

[combat-trainer]>aim
You begin to target a granite gargoyle.

[combat-trainer]>prepare HP 5
That won't affect your current attunement very much.
With tense movements you prepare your body for the Heighten Pain spell.

[combat-trainer]>hunt
You take note of all the tracks in the area, so that you can hunt anything nearby down.

To the north:

  1. a granite gargoyle
    To the southwest, northwest, northwest:
  2. a granite gargoyle
    To the west, northwest, northwest, northwest:
  3. a granite gargoyle
    Roundtime: 8 sec.
  • Moving in like a timid schoolboy, a granite gargoyle maneuvers at you. You evade, leaping aside.
    [You're incredibly balanced and overwhelming your opponent.]

A loud stomping sound fills the air as a granite gargoyle comes clomping in.

The granite gargoyle begins to advance on you!
The granite gargoyle is still a distance away from you and is closing steadily.

You feel fully prepared to cast your spell.

[combat-trainer]>shoot

  • As if fumbling muscle flab were natural, a granite gargoyle pounds at you. You partially block with a lumium round sipar.
    [You're adeptly balanced and overwhelming your opponent.]

And this is what happens in the PR after the threshold is passed and the aiming_trainable gets bypassed. No more aiming_trainable spam.

@mdr55
Copy link
Contributor Author

mdr55 commented Jan 18, 2025

fine rubocop, if you insist I really really must indent my comments, I will do so

@MahtraDR MahtraDR merged commit 6adf816 into elanthia-online:main Jan 18, 2025
2 checks passed
@MahtraDR
Copy link
Collaborator

Thank you!

@mdr55 mdr55 deleted the CT-aiming-trainables-improvement2 branch January 18, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants