[script][combat-trainer] make aiming_trainables stop attacking if locked/close to lock #7062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming_trainables have a tendency to lock early due to low RTs + being able to be off-handed. The current behaviour is that even if the aiming_trainable is locked, it will continue to be used, and have a significant chance of "kill-stealing" from the loadable weapon, with no benefit.
The check introduced here will stop the aiming_trainable if its (near-) locked and give the loadable weapon a chance to fire. This should work where the aiming_trainable and the loadable weapon competing for kills are close-ish in rank. Conversely if an overskilled aiming_trainable is used in a backhunt, the dabbling MS will not trigger the check; CT will continue to spam the dabbling aiming_trainable in that case (which will never lock due to nature of backhunt - same as main hand weapons).
Don't believe we need a yaml switch for this, the change should become the new default behaviour?