-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[script][combat-trainer] Stop training untrainable weapon skills in CT - optional feature #7068
Open
mdr55
wants to merge
9
commits into
elanthia-online:main
Choose a base branch
from
mdr55:CT-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b73b1b8
Update combat-trainer.lic
mdr55 98835dd
Update combat-trainer.lic
mdr55 e368fe1
Update combat-trainer.lic
mdr55 7dedbb7
Update combat-trainer.lic
mdr55 27efb46
Update combat-trainer.lic
mdr55 9cab690
Update combat-trainer.lic
mdr55 a5ef050
Merge branch 'elanthia-online:main' into CT-upgrade
mdr55 8764a8a
Update combat-trainer.lic
mdr55 7f1c047
Update combat-trainer.lic
mdr55 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this assignment for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've just switched weapons so the old @last_exp is no longer valid. The new weapon's @last_exp = -1 guarantees it will pass the mindstate portion of the check. Its not strictly necessary, worst case is new weapon gets a mark against it, only to be reset to 0 at the cycle after. But its nice to reset properly on weapon change, seeing as line 176 does something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, you can add an attr reader for it in GameState, then just reference
game_state.last_exp
here insteadThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaah right, scoping, i'll fix that. it mustn't have been working before?