Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks: clean up infra logs #15198

Merged
merged 2 commits into from
Jan 10, 2025
Merged

benchmarks: clean up infra logs #15198

merged 2 commits into from
Jan 10, 2025

Conversation

endorama
Copy link
Member

@endorama endorama commented Jan 9, 2025

Motivation/summary

Clean up benchmarks GitHub Actions workflow to reduce logging from curl used to setup the ephimeral test clusters.

Checklist

How to test these changes

Related issues

The response from curl could contain secrets for the test
ephimeral cluster. There is no need to display it unless
an error occurred, when we may need it for debugging purposes.
@endorama endorama requested a review from a team as a code owner January 9, 2025 17:10
Copy link
Contributor

mergify bot commented Jan 9, 2025

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Jan 9, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 9, 2025
@endorama endorama enabled auto-merge (squash) January 9, 2025 18:44
@endorama endorama disabled auto-merge January 9, 2025 18:44
@endorama endorama enabled auto-merge (squash) January 10, 2025 08:31
@endorama endorama merged commit 1261584 into main Jan 10, 2025
11 checks passed
@endorama endorama deleted the fix-ephimeral-secrets branch January 10, 2025 08:43
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
The response from curl could contain secrets for the test
ephimeral cluster. There is no need to display it unless
an error occurred, when we may need it for debugging purposes.

(cherry picked from commit 1261584)
mergify bot added a commit that referenced this pull request Jan 10, 2025
The response from curl could contain secrets for the test
ephimeral cluster. There is no need to display it unless
an error occurred, when we may need it for debugging purposes.

(cherry picked from commit 1261584)

Co-authored-by: Edoardo Tenani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants