Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added loggers for Fleet enrollment call failures #6477

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

Rohit-code14
Copy link
Contributor

  • Enhancement

What does this PR do?

Added logger to print the status and code when enrollment call to fleet failed.

Why is it important?

As mentioned in the issue(#6287), It will be difficult to debug enrollment failures in such cases. Therefore adding the actual status code and error in logs will be helpful for debugging.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

No disruptive user impact

Related issues

@Rohit-code14 Rohit-code14 requested a review from a team as a code owner January 4, 2025 14:58
Copy link
Contributor

mergify bot commented Jan 4, 2025

This pull request does not have a backport label. Could you fix it @Rohit-code14? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@michalpristas michalpristas added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jan 6, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pkoutsovasilis
Copy link
Contributor

buildkite test this

@pkoutsovasilis
Copy link
Contributor

buildkite test this

1 similar comment
@pkoutsovasilis
Copy link
Contributor

buildkite test this

@Rohit-code14
Copy link
Contributor Author

@pkoutsovasilis not sure why the buildkite test is failing..shall i merge latest changes to my branch once again? And will i be able to trigger test by commenting buildkite test this or is it only for elastic team members?

@michel-laterman
Copy link
Contributor

buildkite test this

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution @Rohit-code14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote server failed to handle the request, will retry in a moment needs to be better handled
5 participants