Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry support #70

Merged
merged 8 commits into from
Jun 25, 2024
Merged

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jun 24, 2024

Closes #52

Unlike #69 which mostly was code generation, this is the actual implementation.

Backports elastic/elasticsearch-py#2466, elastic/elasticsearch-py#2470, elastic/elasticsearch-py#2479, elastic/elasticsearch-py#2490 and elastic/elasticsearch-py#2491

@pquentin pquentin force-pushed the record-otel-spans branch from 3405d70 to 4adcf84 Compare June 24, 2024 13:58
@pquentin pquentin mentioned this pull request Jun 24, 2024
7 tasks
@pquentin pquentin requested a review from miguelgrinberg June 24, 2024 14:12
Copy link
Contributor

@miguelgrinberg miguelgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but note that the tests in the two test_otel.py files are being skipped. Should these run?

@pquentin
Copy link
Member Author

They run on Buildkite, see the test_otel jobs.

@pquentin
Copy link
Member Author

Closing/reopening to see if Read the Docs integration works.

@pquentin pquentin closed this Jun 25, 2024
@pquentin pquentin reopened this Jun 25, 2024
@pquentin
Copy link
Member Author

I also tested that well, it actually worked, and yes:

image

@pquentin pquentin merged commit b44f72e into elastic:main Jun 25, 2024
17 of 18 checks passed
@pquentin pquentin changed the title Record OpenTelemetry spans Add OpenTelemetry support Jun 25, 2024
@pquentin pquentin deleted the record-otel-spans branch June 25, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OpenTelemetry support
2 participants