Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins murmurhash3 to last version with java library #14832

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Jan 9, 2023

Release notes

[rn:skip]

What does this PR do?

Pins the murmurhash3 to the last version that provided Java version

Why is it important/What is the impact to the user?

Avoid errors in compiling latest main

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Error Bundler::InstallError, retrying 1/10
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/murmurhash3-0.1.7/ext/murmurhash3
/home/andrea/.sdkman/candidates/java/11.0.15-tem/bin/java -cp :/home/andrea/.gradle/caches/jars-9/4b7ea7ee921889f32773847de07d0ab6/snakeyaml-1.29.jar:/home/andrea/.gradle/caches/jars-9/466e6dbe9ac6d19b03a1f3c7e06e9799/gradle-download-task-4.0.4.jar:/home/andrea/.gradle/caches/jars-9/e47ff9aeec92c7ee54aefd6c530ecbae/jruby-complete-9.3.9.0.jar org.jruby.Main -I uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib -r ./siteconf20230109-99722-vy7131.rb extconf.rb
Exception in thread "main" java.lang.NoClassDefFoundError: org/gradle/internal/classpath/Instrumented
        at com.headius.options.Option.loadProperty(Option.java:400)
        at com.headius.options.IntegerOption.reloadValue(IntegerOption.java:38)
        at com.headius.options.IntegerOption.reloadValue(IntegerOption.java:20)
        at com.headius.options.Option.reload(Option.java:431)
        at com.headius.options.Option.load(Option.java:422)
        at org.jruby.util.cli.Options.<clinit>(Options.java:95)
        at org.jruby.util.log.LoggerFactory.<clinit>(LoggerFactory.java:36)
        at org.jruby.Main.<clinit>(Main.java:86)
Caused by: java.lang.ClassNotFoundException: org.gradle.internal.classpath.Instrumented
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
        ... 8 more

extconf failed, exit code 1

Gem files will remain installed in /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/murmurhash3-0.1.7 for inspection.
Results logged to /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/extensions/universal-java-11/2.6.0/murmurhash3-0.1.7/gem_make.out

  uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/ext/builder.rb:93:in `run'
  uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/ext/ext_conf_builder.rb:47:in `block in build'
  org/jruby/ext/tempfile/Tempfile.java:242:in `open'
  uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/ext/ext_conf_builder.rb:26:in `build'
  uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/ext/builder.rb:159:in `build_extension'
  uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/ext/builder.rb:193:in `block in build_extensions'
  org/jruby/RubyArray.java:1865:in `each'
  uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/ext/builder.rb:190:in `build_extensions'
  uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/installer.rb:837:in `build_extensions'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/rubygems_gem_installer.rb:71:in `build_extensions'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/rubygems_gem_installer.rb:28:in `install'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/source/rubygems.rb:207:in `install'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/installer/gem_installer.rb:54:in `install'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/installer/gem_installer.rb:16:in `install_from_spec'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/installer/parallel_installer.rb:186:in `do_install'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/installer/parallel_installer.rb:177:in `block in worker_pool'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/worker.rb:62:in `apply_func'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/worker.rb:57:in `block in process_queue'
  org/jruby/RubyKernel.java:1507:in `loop'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/worker.rb:54:in `process_queue'
  /home/andrea/workspace/logstash_andsel/vendor/bundle/jruby/2.6.0/gems/bundler-2.3.18/lib/bundler/worker.rb:91:in `block in create_threads'

An error occurred while installing murmurhash3 (0.1.7), and Bundler cannot continue.

In Gemfile:
  logstash-filter-anonymize was resolved to 3.0.6, which depends on
    murmurhash3

@andsel andsel self-assigned this Jan 9, 2023
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense!
Let's wait for 🟢 CI.

@jsvd
Copy link
Member

jsvd commented Jan 24, 2023

@logstashmachine backport 7.17

andsel added a commit to andsel/logstash that referenced this pull request Jan 24, 2023
jsvd pushed a commit that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Murmurhash3 0.1.7 doesn't provide java version
3 participants