Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to Python3.13 #19

Merged
merged 21 commits into from
Nov 26, 2024
Merged

Prepare to Python3.13 #19

merged 21 commits into from
Nov 26, 2024

Conversation

elazarg
Copy link
Owner

@elazarg elazarg commented Nov 26, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a new instrument function in the scripts/instrument.sh file to execute a Python script with specific command-line arguments.
    • Added a new flag --step in multiple experiment configurations to control step parameters.
    • New functions for managing CRIU options and handling coredumps have been implemented.
  • Bug Fixes

    • Updated the persist.self_coredump() method calls to include descriptive string arguments for better logging.
  • Refactor

    • Simplified the argument parsing in instrument.py, enhancing the command-line interface.
    • Restructured CRIU-related functionality in checkpoint/persist.py for clarity and modularization.
  • Documentation

    • Updated comments and descriptions in various files for better understanding of the changes.
  • Chores

    • Removed the matplotlib dependency from requirements.txt.

Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
Signed-off-by: Elazar Gershuni <[email protected]>
@elazarg elazarg merged commit 8827903 into master Nov 26, 2024
1 check passed
Copy link

coderabbitai bot commented Nov 26, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request include the addition of a new file checkpoint/criu.py that implements functions and a context manager for managing CRIU (Checkpoint/Restore In Userspace) options. The existing checkpoint/criu_binding.py file is removed, consolidating CRIU functionality into the new file. The .gitignore file is updated to ignore criu_images. Other modifications include updates to several K-Means clustering scripts, adjustments to argument parsing in instrument.py, and enhancements to various files related to error handling and functionality improvements across the codebase.

Changes

File Change Summary
.gitignore Added entry for criu_images to be ignored by Git.
checkpoint/criu.py New file defining CRIU-related functions and a context manager.
checkpoint/criu_binding.py Removed file that contained CRIU function bindings.
checkpoint/ctypes_modern.py Updated Clibrary constructor to accept an optional namespace_prefix.
checkpoint/persist.py Refactored CRIU handling; added init_opts and make_dump functions.
experiment/k_means/flags.txt Added new flag --step=1.
experiment/k_means/instrumented.py Modified centroid calculation logic in run function.
experiment/k_means/main.py Updated centroid calculation in run function.
experiment/k_means/naive.py Adjusted nearest centroid calculation in run function.
experiment/k_means/proc.py Modified persist.self_coredump() call to include a string argument.
experiment/k_means/vm.py Updated nearest centroid calculation in run function.
experiment/omp/args.txt Changed --k parameter value from 200 to 35.
experiment/omp/flags.txt Added new flag --step=1.
experiment/omp/proc.py Modified persist.self_coredump() call to include a string argument.
experiment/pivoter/flags.txt Added new flag --step=50.
experiment/pivoter/proc.py Modified persist.self_coredump() call to include a string argument.
experiment/trivial/flags.txt Added new flag --step=1.
experiment/trivial/proc.py Updated persist.self_coredump() call to include a string argument.
instrument.py Enhanced argument parsing; added --no-generate flag.
pythia/ast_transform.py Updated make_coredump and added new make_for_tcp function.
pythia/dom_typed_pointer.py Added collect_garbage method and updated unop_to_str function.
pythia/instruction_cfg.py Updated is_jump function for Python version checks.
pythia/tac.py Added new BOOL operation to UnOp enum and updated handling for bytecode.
pythia/type_system.py Enhanced operator mapping for "bool".
requirements.txt Removed matplotlib==3.9.0 dependency.
scripts/instrument.sh Added instrument function to execute instrument.py.
scripts/selfcheckpoint.c Renamed function from set_criu to setup_criu.
test_data/iteration.py Removed pair function; added simple_tuple and modified related functions.
test_data/lists.py Added list_set function to modify list elements.
tests/test_generate.py Updated proc_transform function to include a tag parameter.
typeshed_mini/numpy.pyi Expanded ndarray class capabilities and updated method signatures.

Poem

🐰 In the code where rabbits dwell,
New functions rise, all is well.
CRIU's magic, a leap we take,
With flags and steps, no mistake!
From lists to tuples, we hop and play,
In this code garden, we’ll dance all day! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@elazarg elazarg deleted the python3.13 branch November 26, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant