Update com.github.ztefn.haguichi to 1.146.1 #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Looks really good, nice work! Thanks for adding screenshot captions!
One thing I'd recommend to investigate using portals more.
- There is a built-in method to Gtk.Application for monitoring session state: https://valadoc.org/gtk4/Gtk.Application.screensaver_active.html
- I would also recommend looking at using the background portal to make sure we're properly asking for permission to run in the background and providing a reason/status etc: https://valadoc.org/libportal/Xdp.Portal.request_background.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased elementary branch on top of master, from commit 6e6f411 to d46f457. Runtime updated to 7.2.
Release tag: 1.146.1
Review Checklist
AppData
Flatpak