-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add App Generator #534
Add App Generator #534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for submitting this!
A major problem here is that you don't actually own this RDNN. https://github.com/ecommunity
is owned by someone else. The RDNN here should be io.github.elementary-community.app-generator
since that's where it's hosted. That's why I asked previously if you wanted to make move the org domain to something shorter :)
The screenshot in this release doesn't match the app as released here. I would also recommend versioning this URL so that it pulls the right screenshot, for example, it should be https://raw.githubusercontent.com/elementary-community/app-generator/1.0.0/data/io.github.ecommunity.app-generator.png
In metainfo, the <developer_name>
is deprecated. The <developer>
tag should be used instead https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer
<value key="x-appcenter-color-primary-text">
is no longer used. Text color is generated automatically in AppCenter
Your metainfo file is missing a <content_rating>
tag. This can just be a self-closing tag if there's nothing to disclose https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-content_rating
Maybe it should be https://docs.flatpak.org/en/latest/conventions.html#application-ids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still an issue with the screenshot here. It is missing window shadows and appears to be unfocused, but I'll let it through this time since I know you've been waiting on this for a while and I'm sure you'll have more updates soon :)
Review Checklist
AppData
Flatpak