-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DnD reordering #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I can remove unpined apps by dragging into nothing.
And I think the |
Unpinned apps can't be removed anymore. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Hmm just removing an app nothing else? |
@leolost2605 yep |
@lenemter that is strange, cause I don't get these glitches... |
TBH I'm not familiar with this either. I remember seeing similar glitches in Sideload app and the cause was that window didn't smoothly change its size. It was easy to fix thanks to Gtk.Stack.interpolate_size, but since here's no stack used, I don't know if that can be the source of issues.
Oh yes, I do. It's a bit small though. |
Co-authored-by: Leo <[email protected]>
Ok the last commit adds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took so long to review. I left inline comments on things I personally don't like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this branch in Wayland session and it's totally broken, you can't remove an app using dragging, and when dragging there is no icon at all. This is definitely some Wayland issues, so worth asking @tintou
@lenemter Would you be okay with merging for now since it's working in X and then we can keep iterating since we're such early days here? It would be nice to keep momentum going to replace plank ASAP imo |
@leolost2605 can you resolve conflicts here please? :) |
@danirabbit done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something we have to revisit later but it's good enough to start testing the dock. Thanks for working on this <3
Pretty much replicates the plank remove and reorder experience 1 : 1